Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix super linter config #10

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Conversation

MaxMustermann2
Copy link
Contributor

The super-linter.yml workflow seems to be running on pull requests and branches. However, for pull requests, it fails silently with the logs reporting an error. On branches, it fails actually with an ❌ emoji.

The super-linter.yml workflow seems to be running on pull requests and
branches. However, for pull requests, it fails silently with the logs
reporting an error. On branches, it fails actually with an ❌ emoji.
@MaxMustermann2
Copy link
Contributor Author

The failing lint check here is, again, the protobuf's break-check. There is a singular non-comment change within the proto files, which is fixing a typo of a field in an unused module. Hence, it can be ignored.

Copy link
Contributor

@TimmyExogenous TimmyExogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxMustermann2 MaxMustermann2 merged commit 65e90a6 into develop Mar 4, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants